Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#80 json view reader codemirror #243

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Feature/#80 json view reader codemirror #243

merged 8 commits into from
Nov 9, 2023

Conversation

migalko94
Copy link
Collaborator

No description provided.

juanpms2
juanpms2 reviewed Nov 9, 2023
View reviewed changes
apps/react-app/src/common-app/components/codemirror/codemirror.styles.ts Outdated
'.cm content, .cm-gutters,': {
minHeight: '100%',
backgroundColor: '#152128',
color: '#AAB0B1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this theme color here, please
color: theme.palette.light[500]

@juanpms2
Copy link
Member

juanpms2 commented Nov 9, 2023 •
edited
Loading

Please, add this styles for Google Chrome scrollbar in app.global-styles.ts after the body label.

 & ::-webkit-scrollbar {
    width: 8px;
  }

  & ::-webkit-scrollbar-track {
    background-color: none;
    border-radius: 4px;

    &:hover {
      background-color: rgba(0, 0, 0, 0.6);
    }
  }

  & ::-webkit-scrollbar-thumb {
    background-color: #9e9e9e;
    border-radius: 4px;
  }

@brauliodiez brauliodiez merged commit 13db015 into Lemoncode:feature/develop Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpms2 juanpms2 juanpms2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migalko94 @juanpms2 @brauliodiez